[Notifier] Only use sprintf instead of sprintf and string concat #39412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | --- |
| License | MIT |
| Doc PR | --- |
nicolas-grekas
previously requested changes
Dec 9, 2020
| @@ -24,7 +24,7 @@ public function __construct(string $message, string $dsn = null, ?\Throwable $pr | |||
| { | |||
| $this->dsn = $dsn; | |||
| if ($dsn) { | |||
| $message = sprintf('Invalid "%s" notifier DSN: ', $dsn).$message; | |||
| $message = sprintf('Invalid "%s" notifier DSN: %s', $dsn, $message); | |||
There was a problem hiding this comment.
this was on purpose, because fabbot used to scream at %s that are not surrounded by double quotes.
Not sure why it doesn't scream anymore at these.
This should be double checked before merging!
There was a problem hiding this comment.
oh, I can answer myself ...:P
this is not in a throw expression, that's why.
| @@ -24,7 +24,7 @@ public function __construct(string $message, string $dsn = null, ?\Throwable $pr | |||
| { | |||
| $this->dsn = $dsn; | |||
| if ($dsn) { | |||
| $message = sprintf('Invalid "%s" notifier DSN: ', $dsn).$message; | |||
| $message = sprintf('Invalid "%s" notifier DSN: %s', $dsn, $message); | |||
There was a problem hiding this comment.
oh, I can answer myself ...:P
this is not in a throw expression, that's why.
Ok |
69ca323 to
ca65c54
Compare
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.