8000 [Notifier] Only use sprintf instead of sprintf and string concat by OskarStark · Pull Request #39412 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Only use sprintf instead of sprintf and string concat #39412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[Notifier] Only use sprintf instead of sprintf and string concat #39412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Exception/IncompleteDsnException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function __construct(string $message, string $dsn = null, ?\Throwable $pr
{
$this->dsn = $dsn;
if ($dsn) {
$message = sprintf('Invalid "%s" notifier DSN: ', $dsn).$message;
$message = sprintf('Invalid "%s" notifier DSN: %s', $dsn, $message);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was on purpose, because fabbot used to scream at %s that are not surrounded by double quotes.
Not sure why it doesn't scream anymore at these.
This should be double checked before merging!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I can answer myself ...:P
this is not in a throw expression, that's why.

}

parent::__construct($message, 0, $previous);
Expand Down
0