[2.2] [FrameworkBundle][Translation] Added logging capability to translator #3890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -337,6 +337,7 @@ private function addTranslatorSection(ArrayNodeDefinition $rootNode) | |||
| ->treatTrueLike(array('enabled' => true)) | |||
| ->children() | |||
| ->booleanNode('enabled')->defaultTrue()->end() | |||
| ->booleanNode('enable_logging')->defaultFalse()->end() | |||
There was a problem hiding this comment.
it should simply be named logging to be consistent with DoctrineBundle
|
Subscribing... This feature would be useful right now... Sad it's not merged yet. |
| { | ||
| if (null !== $this->logger && !$catalogue->defines($id, $domain)) { | ||
| if ($catalogue->has($id, $domain)) { | ||
| $this->logger->notice('Translator: using fallback catalogue.', array('id' => $id, 'domain' => $domain)); |
There was a problem hiding this comment.
@meandmymonkey Thanks for making this PR. I know that a lot of time passed but could you also pass locale ($this->getLocale()) to the logger?
|
This needs some tests |
|
Github seems to have lost the reference to the commits in my repo, probably because I messed with my fork since the commits in April. I' closing this and re-opening here: #5537 Method ist renamed, tests will follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3015
Todo: -
Adds logging capabilities to
Symfony\Bundle\FrameworkBundle\Translation\Translator. Logging is switchable through the newloggingconfig flag and defaults tofalse.A minor addition to the Translation Component was necessary to avoid complete duplication of
trans()andtransChoice().