[Form] Fixed behavior of empty value if already defined #3864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function valuesContains($searchValue) | ||
| { | ||
| foreach ($this->values as $value) | ||
| { |
There was a problem hiding this comment.
This should be in same line as foreach
|
Fixed, thanks @stloyd |
| * | ||
| * @return boolean | ||
| */ | ||
| function valuesContains($searchValue); |
There was a problem hiding this comment.
wrong English. valuesContain would be correct but is not really nice anyway.
There was a problem hiding this comment.
@Tobion Do you have better naming suggestion? Otherwise I'll correct the english :)
|
@bschussek: Ping? |
|
@fspillner Thank you for the PR! The implementation is not correct though. You are checking whether the values contain the contents of the "empty_value" option, but this option contains the label of the empty value I fixed this issue in the referenced PR #4801. |
fabpot
added a commit
that referenced
this pull request
Jul 9, 2012
Commits ------- 040ba8f [Form] Fixed: ChoiceType omits the "empty_value" option if the choices contain an empty element Discussion ---------- [Form] Fixed: ChoiceType omits the "empty_value" option if the choices contain an empty element Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #3854, #3864 Todo: -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3854
Todo: -