8000 [Form] Don't add empty choice if already present · Issue #3854 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Don't add empty choice if already present #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
webmozart opened this issue Apr 10, 2012 · 1 comment
Closed

[Form] Don't add empty choice if already present #3854

webmozart opened this issue Apr 10, 2012 · 1 comment
Labels
Bug Form

Comments

@webmozart
Copy link
Contributor

If the choices passed to ChoiceType already contain the empty choice "", no new empty choice should be generated if the field is not required.
@webmozart
Copy link
Contributor Author

Related to #3154

@fspillner fspillner mentioned this issue Apr 10, 2012
Closed
@webmozart webmozart mentioned this issue Jul 9, 2012
Merged
fabpot added a commit that referenced this issue Jul 9, 2012
@fabpot
merged branch bschussek/issue3864 (PR #4801)
38c30b7 
Commits
-------

040ba8f [Form] Fixed: ChoiceType omits the "empty_value" option if the choices contain an empty element

Discussion
----------

[Form] Fixed: ChoiceType omits the "empty_value" option if the choices contain an empty element

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3854, #3864
Todo: -
@fabpot fabpot closed this as completed Jul 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @webmozart
0