8000 [Messenger][Doctrine] Avoid early db access for pgsql detection by chalasr · Pull Request #38618 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger][Doctrine] Avoid early db access for pgsql detection #38618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

[Messenger][Doctrine] Avoid early db access for pgsql detection #38618

merged 1 commit into from
Oct 19, 2020

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Oct 18, 2020
Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37069
License MIT
Doc PR -

Keeps the connection lazy using an instanceof check on the DBAL driver instead.

@chalasr chalasr added this to the 5.1 milestone Oct 18, 2020
@chalasr chalasr requested a review from sroze as a code owner October 18, 2020 11:37
@chalasr chalasr mentioned this pull request Oct 18, 2020
Closed
lyrixx
lyrixx approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member
@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 super simple, love it

@derrabus derrabus requested a review from stof October 18, 2020 13:13
@fabpot
Copy link
Member
fabpot commented Oct 19, 2020

Thank you @chalasr.

@fabpot fabpot merged commit 4fdacdb into symfony:5.1 Oct 19, 2020
@chalasr chalasr deleted the msg-postgre-lazy branch October 19, 2020 07:45
This was referenced Oct 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@derrabus derrabus derrabus approved these changes

@sroze sroze Awaiting requested review from sroze

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Bug Doctrine Messenger Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @lyrixx @derrabus @carsonbot
0