bug #38618 [Messenger][Doctrine] Avoid early db access for pgsql detection (chalasr)

fabpot · fabpot · commit 4fdacdb3a3db · 2020-10-19T08:27:35.000+02:00
This PR was merged into the 5.1 branch. Discussion ---------- [Messenger][Doctrine] Avoid early db access for pgsql detection | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37069 | License | MIT | Doc PR | - Keeps the connection lazy using an instanceof check on the DBAL driver instead. Commits ------- c4cc4a3 [Messenger][Doctrine] Avoid early db access for pgsql detection
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineTransportFactory.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineTransportFactory.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Messenger\Bridge\Doctrine\Transport;
 
+use Doctrine\DBAL\Driver\AbstractPostgreSQLDriver;
 use Doctrine\Persistence\ConnectionRegistry;
 use Symfony\Bridge\Doctrine\RegistryInterface;
 use Symfony\Component\Messenger\Exception\TransportException;
@@ -47,7 +48,7 @@ public function createTransport(string $dsn, array $options, SerializerInterface
             throw new TransportException(sprintf('Could not find Doctrine connection from Messenger DSN "%s".', $dsn), 0, $e);
         }
 
-        if ($useNotify && ($wrappedConnection = $driverConnection->getWrappedConnection()) && method_exists($wrappedConnection, 'pgsqlGetNotify')) {
+        if ($useNotify && $driverConnection->getDriver() instanceof AbstractPostgreSQLDriver) {
             $connection = new PostgreSqlConnection($configuration, $driverConnection);
         } else {
             $connection = new Connection($configuration, $driverConnection);
