[WebProfilerBundle] Hide debug toolbar in print view #38606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 16, 2020
fabpot
approved these changes
Oct 16, 2020
|
Thank you @jt2k. |
|
Thanks, @fabpot and @stof. I see this is already merged, but I am curious about your comment, @jderusse. According to the release page, 3.4 is maintained for bug fixes until November 2020. Are we in a window now where bug fixes targeting 3.4 are discouraged due to the proximity to November 2020? |
|
@jt2k yes, you're right. sorry for the confusion |
8000
|
@jderusse No problem! That was a good reminder for me that 3.4 is going into security-only maintenance soon! |
This was referenced Oct 28, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug toolbar is intended to be hidden when printed. This was accomplished in 2.8 with this PR. Since then, additional JavaScript code was added which results in
display: blockbeing applied directly to the toolbar element. This overrides the print style, which causes the toolbar to show up in the print view. I fixed this by adding!importantto the print CSS display rule.A few notes:
!importantbut couldn't come up with another way to make this work with the existing JavaScript code. Also,profiler.css.twigalready has some!importantstyles, so I figured this was acceptable.