Don't display the Symfony debug toolbar when printing the page #23460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23303 |
| License | MIT |
| Doc PR | - |
ostrolucky
reviewed
Jul 10, 2017
| @media print { | ||
| .sf-toolbar, .sf-error-toolbar { | ||
| display: none; | ||
| visibility: hidden; |
There was a problem hiding this comment.
what's the reason for this if there is already display: none?
There was a problem hiding this comment.
It was in the original CSS rule ... but you are right and this is no longer needed (Bootstrap v4 doesn't use that either. See https://github.com/twbs/bootstrap/blob/v4-dev/scss/_print.scss)
xabbuh
approved these changes
Jul 10, 2017
|
Actually, the issue is that the media query hiding the whole toolbar (error one or normal one) is missing now. /***** Media query print: Do not print the Toolbar. *****/
@media print {
.sf-toolbar {
display: none;
visibility: hidden;
}
}But the 2.8 branch does not seem to have it anymore. I suspect a bad conflict resolution when merging branches |
stof
requested changes
Jul 10, 2017
|
|
||
| /***** Media query print: Do not print the Toolbar. *****/ | ||
| @media print { | ||
| .sf-toolbar, .sf-error-toolbar { |
There was a problem hiding this comment.
.sf-error-toolbar is useless here, as the error toolbar also has the sf-toolbar class
|
Thank you @javiereguiluz. |
This was referenced Jul 17, 2017
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Oct 16, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [WebProfilerBundle] Hide debug toolbar in print view | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT The debug toolbar is intended to be hidden when printed. This was accomplished in 2.8 with [this PR](#23460). Since then, additional JavaScript code was added which results in `display: block` being applied directly to the toolbar element. This overrides the print style, which causes the toolbar to show up in the print view. I fixed this by adding `!important` to the print CSS display rule. A few notes: 1. I hesitated to solve this with `!important` but couldn't come up with another way to make this work with the existing JavaScript code. Also, `profiler.css.twig` already has some `!important` styles, so I figured this was acceptable. 2. I wasn't sure how to write a test for this, but I am open to ideas. Commits ------- fb30516 [WebProfilerBundle] Hide debug toolbar in print view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.