[Form] Fixed handling of empty values in checkbox/radio/choice type #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buttons with empty values ("")
|
You probably need to change some things in the CHANGELOG file too |
|
No. This is an update of a previous post-2.0 PR, the CHANGELOG is still accurate. |
|
well, doesn't it require changes to the description of previous changes related to the ChoiceList ? It does in the UPGRADE file so it is weird if the CHANGELOG does not require any change. |
|
Feel free to check yourself :) |
… include the choice index
fabpot
added a commit
that referenced
this pull request
Apr 10, 2012
Commits ------- 61d792e [Form] Changed checkboxes in an expanded multiple-choice field to not include the choice index bc9bc4a [Form] Fixed behavior of expanded multiple-choice field when submitted without ticks 2e07256 [Form] Simplified choice list API 2645120 [Form] Fixed handling of expanded choice lists, checkboxes and radio buttons with empty values ("") Discussion ---------- [Form] Fixed handling of empty values in checkbox/radio/choice type Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #3839, #3366 Todo: -  This PR fixes the processing of checkboxes and radio buttons with empty "value" attributes as well as of expanded choice forms with empty values. Additionally, some unnecessary complexity has been removed of the new ChoiceList API. --------------------------------------------------------------------------- by stof at 2012-04-10T13:56:12Z You probably need to change some things in the CHANGELOG file too --------------------------------------------------------------------------- by bschussek at 2012-04-10T14:39:24Z No. This is an update of a previous post-2.0 PR, the CHANGELOG is still accurate. ------------------------------------------------------- 6F7F -------------------- by stof at 2012-04-10T14:46:47Z well, doesn't it require changes to the description of previous changes related to the ChoiceList ? It does in the UPGRADE file so it is weird if the CHANGELOG does not require any change. --------------------------------------------------------------------------- by bschussek at 2012-04-10T14:56:05Z Feel free to check yourself :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3839, #3366
Todo: -
This PR fixes the processing of checkboxes and radio buttons with empty "value" attributes as well as of expanded choice forms with empty values. Additionally, some unnecessary complexity has been removed of the new ChoiceList API.