8000 [Form] Fix choices with empty values when expanded and COPY_CHOICE · Issue #3839 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fix choices with empty values when expanded and COPY_CHOICE #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
webmozart opened this issue Apr 8, 2012 · 1 comment
Closed

[Form] Fix choices with empty values when expanded and COPY_CHOICE #3839

webmozart opened this issue Apr 8, 2012 · 1 comment
Labels
Bug Form

Comments

@webmozart
Copy link
Contributor

When using expanded choice fields (single and multiple choice) and empty strings as values and using the value strategy COPY_CHOICE, and the form is submitted with the empty value selected, the empty value does not appear as selected after binding.

The foundation of this problem seems to be that checkboxes with a value "" cannot be submitted as checked (and radio buttons likewise, I suppose).
@webmozart
Copy link
Contributor Author

See https://github.com/symfony/symfony/pull/3156/files#L1R94 for reference.

@webmozart webmozart mentioned this issue Apr 10, 2012
Merged
fabpot added a commit that referenced this issue Apr 10, 2012
@fabpot
merged branch bschussek/issue3839 (PR #3859)
517f8e0 
Commits
-------

61d792e [Form] Changed checkboxes in an expanded multiple-choice field to not include the choice index
bc9bc4a [Form] Fixed behavior of expanded multiple-choice field when submitted without ticks
2e07256 [Form] Simplified choice list API
2645120 [Form] Fixed handling of expanded choice lists, checkboxes and radio buttons with empty values ("")

Discussion
----------

[Form] Fixed handling of empty values in checkbox/radio/choice type

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3839, #3366
Todo: -

![Travis Build Status](https://secure.travis-ci.org/bschussek/symfony.png?branch=issue3839)

This PR fixes the processing of checkboxes and radio buttons with empty "value" attributes as well as of expanded choice forms with empty values. Additionally, some unnecessary complexity has been removed of the new ChoiceList API.

---------------------------------------------------------------------------

by stof at 2012-04-10T13:56:12Z

You probably need to change some things in the CHANGELOG file too

---------------------------------------------------------------------------

by bschussek at 2012-04-10T14:39:24Z

No. This is an update of a previous post-2.0 PR, the CHANGELOG is still accurate.

---------------------------------------------------------------------------

by stof at 2012-04-10T14:46:47Z

well, doesn't it require changes to the description of previous changes related to the ChoiceList ? It does in the UPGRADE file so it is weird if the CHANGELOG does not require any change.

---------------------------------------------------------------------------

by bschussek at 2012-04-10T14:56:05Z

Feel free to check yourself :)
@fabpot fabpot closed this as completed Apr 10, 2012
@webmozart webmozart mentioned this issue Apr 12, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @webmozart
0