[HttpClient] add RetryStrategyInterface#38466
Closed
nicolas-grekas wants to merge 1 commit intosymfony:5.xfrom
Closed
[HttpClient] add RetryStrategyInterface#38466nicolas-grekas wants to merge 1 commit intosymfony:5.xfrom
nicolas-grekas wants to merge 1 commit intosymfony:5.xfrom
Conversation
nicolas-grekas
added a commit
that referenced
this pull request
Oct 13, 2020
…tegyInterface (nicolas-grekas) This PR was merged into the 5.x branch. Discussion ---------- [HttpClient] simplify retry mechanism around RetryStrategyInterface | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replaces #38466 I feel like the mechanism behind RetryableHttpClient is too bloated for no pragmatic reasons. I propose to merge RetryDeciderInterface and RetryBackoffInterface into one single RetryStrategyInterface. Having two separate interfaces supports no real-world use case. The only implementations we provide are trivial, and they can be reused by extending the provided GenericRetryStrategy implementation if one really doesn't want to duplicate that. The methods are also simplified by accepting an AsyncContext as argument. This makes the signatures shorter and allows accessing the "info" of the request (allowing to decide based on the IP of the host, etc). /cc @jderusse Commits ------- 544c3e8 [HttpClient] simplify retry mechanism around RetryStrategyInterface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #38420
Inspired by #38415, this gives more flexibility to the
Retry\*logic.Notably:
$retryCountis added toRetryDeciderInterface::shouldRetry()RetryTokenvalue object is introduced, to provide greater extensibility (adding new methods in the retry logic will be easier via a class vs an interface) and to enable strategies to track a single request across retries (allowing to keep the strategy service stateless when request tracking is desired).For thoughts, /cc @jderusse