[HttpClient] add RetryStrategyInterface#38420
Closed
nicolas-grekas wants to merge 1 commit intosymfony:masterfrom
Closed
[HttpClient] add RetryStrategyInterface#38420nicolas-grekas wants to merge 1 commit intosymfony:masterfrom
nicolas-grekas wants to merge 1 commit intosymfony:masterfrom
Conversation
42f9b9b to
4c56aeb
Compare
fabpot
added a commit
that referenced
this pull request
Oct 20, 2020
…derusse) This PR was merged into the 5.x branch. Discussion ---------- [HttpClient] Parameterize list of retryable methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | / | License | MIT | Doc PR | TODO Retrying non-idempotent methods is not always acceptable for user. This PR adds an easy way to configure this behavior. The `RetryDeciderInterface::shouldRetry()` now take the exception in parameter, in order to let decider not retrying the request when the methods should never by retried. With #38420, this code would belongs to the RetryStrategy implementation, and would return an `NeverRetryDecider` when method is not allowed. Commits ------- 56809d1 Parameterize list of retryed Http methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #38415, this gives more flexibility to the
Retry\*logic.Notably:
$retryCountis added toRetryDeciderInterface::shouldRetry()RetryTokenvalue object is introduced, to provide greater extensibility (adding new methods in the retry logic will be easier via a class vs an interface) and to enable strategies to track a single request across retries (allowing to keep the strategy service stateless when request tracking is desired).For thoughts, /cc @jderusse