10000 [Security] Improve exception when rate-limiter is not installed and throttling enabled by fabpot · Pull Request #38356 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Improve exception when rate-limiter is not installed and throttling enabled #38356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

[Security] Improve exception when rate-limiter is not installed and throttling enabled #38356

merged 1 commit into from
Sep 30, 2020

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Sep 30, 2020
Q A
Branch? master
Bug fix? yes-ish
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

When the rate-limiter component is not installed and if one enables login throttling, the error message is not easy to understand: Service "limiter._login_local_main": Parent definition "limiter" does not exist..

This fixes the error message to be easier to understand.

/cc @wouterj

@chalasr chalasr added this to the next milestone Sep 30, 2020
@fabpot fabpot changed the title [Security] Improve exceptionwhen rate-limiter is not installed and throttling enabled [Security] Improve exception when rate-limiter is not installed and throttling enabled Sep 30, 2020
@fabpot fabpot merged commit 3c7a131 into symfony:master Sep 30, 2020
@fabpot fabpot deleted the throttling-better-error-message branch September 30, 2020 14:31
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @wouterj @chalasr @nicolas-grekas @carsonbot
0