bug #38356 [Security] Improve exception when rate-limiter is not installed and throttling enabled (fabpot)

fabpot · fabpot · commit 3c7a131ae19c · 2020-09-30T16:22:11.000+02:00
This PR was merged into the 5.2-dev branch. Discussion ---------- [Security] Improve exception when rate-limiter is not installed and throttling enabled | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes-ish | New feature? | no  | Deprecations? | no  | Tickets | n/a  | License | MIT | Doc PR | n/a When the rate-limiter component is not installed and if one enables login throttling, the error message is not easy to understand: `Service "limiter._login_local_main": Parent definition "limiter" does not exist.`. This fixes the error message to be easier to understand. /cc @wouterj Commits ------- 186ecc1 [Security] Improve exceptionwhen rate-limiter is not installed and throttling enabled
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/LoginThrottlingFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/LoginThrottlingFactory.php
@@ -17,6 +17,7 @@
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\RateLimiter\Limiter;
 use Symfony\Component\Security\Http\EventListener\LoginThrottlingListener;
 
 /**
@@ -60,9 +61,13 @@ public function createAuthenticator(ContainerBuilder $container, string $firewal
             throw new \LogicException('Login throttling requires symfony/security-http:^5.2.');
         }
 
+        if (!class_exists(Limiter::class)) {
+            throw new \LogicException('Login throttling requires symfony/rate-limiter to be installed and enabled.');
+        }
+
         if (!isset($config['limiter'])) {
             if (!class_exists(FrameworkExtension::class) || !method_exists(FrameworkExtension::class, 'registerRateLimiter')) {
-                throw new \LogicException('You must either configure a rate limiter for "security.firewalls.'.$firewallName.'.login_throttling" or install symfony/framework-bundle:^5.2');
+                throw new \LogicException('You must either configure a rate limiter for "security.firewalls.'.$firewallName.'.login_throttling" or install symfony/framework-bundle:^5.2.');
             }
 
             FrameworkExtension::registerRateLimiter($container, $config['limiter'] = '_login_'.$firewallName, [
