[Console] reopen inputStream after a ctrl+D/ctrl+Z #38345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67e8b42 to
06d6ace
Compare
06d6ace to
1165217
Compare
stof
reviewed
Sep 29, 2020
| @@ -521,6 +521,7 @@ private function readInput($inputStream, Question $question) | |||
| while (false !== ($char = fgetc($inputStream))) { | |||
| $ret .= $char; | |||
| } | |||
| $this->inputStream = fopen('php://stdin', 'r'); | |||
There was a problem hiding this comment.
what if the input stream being used is not php://stdin ? That's a supported use case (see isInteractiveInput supporting that case explicitly for instance).
Also, this method looks like the wrong place to me, as it is not designed to use $this->inputStream directly.
There was a problem hiding this comment.
That's a very valid point.
I have no idea how to deal with it ^^
There was a problem hiding this comment.
I think I have a solution. I'm testing it on Windows to make sure it works there, as well.
|
It took a while since what I originally had worked on *nix but not on Windows, but I have a solution over here: #38351 |
|
Closing in favor of #38351 |
chalasr
added a commit
that referenced
this pull request
Sep 30, 2020
…'t close input (ramsey) This PR was squashed before being merged into the 5.2-dev branch (closes #38351). Discussion ---------- [Console] clone stream on multiline questions so EOT doesn't close input | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This fixes a bug in the multiline question feature that was introduced in #37683. Today, @epitre commented on #37683 (comment): > If I ask a question AFTER using the multiline option in a previous question, then it seems that the ctrl+d is kind of saved, and the command gets aborted. I'm honestly not sure how I missed this while working on #37683, since I was testing it with multiple questions, but I think it might have resulted from some of the back-and-forth and the lack of ability to effectively test the EOT character from a unit test. The solution was to _clone_ the input stream resource and use the clone to read the multiline input and capture the EOT byte. In this way, the primary input stream is not closed by the EOT. This is similar to @epitre's solution in #38345, but I'm using the `uri` and `mode` from `stream_get_meta_data()` to create the new stream, and if the existing stream has any data and is seekable and writable (like the streams used in the tests), I add the data to the clone and seek to the same offset. I've ensured that this solution works on a question that is in the middle of a series of other questions, and I've tested in on *nix and Windows. I've also improved the tests for multiline questions. While I'm unable to test (with a unit test) that an EOT character effectively stops reading from STDIN while continuing to the next question and prompt, I feel confident that the tests here provide sufficient coverage. Commits ------- ec688a3 [Console] clone stream on multiline questions so EOT doesn't close input
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Sep 30, 2020
…'t close input (ramsey) This PR was squashed before being merged into the 5.2-dev branch (closes #38351). Discussion ---------- [Console] clone stream on multiline questions so EOT doesn't close input | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This fixes a bug in the multiline question feature that was introduced in #37683. Today, @epitre commented on symfony/symfony#37683 (comment): > If I ask a question AFTER using the multiline option in a previous question, then it seems that the ctrl+d is kind of saved, and the command gets aborted. I'm honestly not sure how I missed this while working on #37683, since I was testing it with multiple questions, but I think it might have resulted from some of the back-and-forth and the lack of ability to effectively test the EOT character from a unit test. The solution was to _clone_ the input stream resource and use the clone to read the multiline input and capture the EOT byte. In this way, the primary input stream is not closed by the EOT. This is similar to @epitre's solution in symfony/symfony#38345, but I'm using the `uri` and `mode` from `stream_get_meta_data()` to create the new stream, and if the existing stream has any data and is seekable and writable (like the streams used in the tests), I add the data to the clone and seek to the same offset. I've ensured that this solution works on a question that is in the middle of a series of other questions, and I've tested in on *nix and Windows. I've also improved the tests for multiline questions. While I'm unable to test (with a unit test) that an EOT character effectively stops reading from STDIN while continuing to the next question and prompt, I feel confident that the tests here provide sufficient coverage. Commits ------- ec688a361e [Console] clone stream on multiline questions so EOT doesn't close input
|
@ramsey It works perfectly ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem with the new multiline question.
it appears when you ask a question AFTER a multiline question
It seems STDIN needs to be reopen (<- does it make sense ?).
I have no idea if this is the best way to fix it, but it does fix it ^^