8000 Allow Drupal to wrap the Symfony test listener (5.1 backport) by alexpott · Pull Request #38031 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Allow Drupal to wrap the Symfony test listener (5.1 backport) #38031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Allow Drupal to wrap the Symfony test listener (5.1 backport) #38031

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9bfe7f
Allow Drupal to wrap the Symfony test listener
fabpot Aug 23, 2020
ee8cc26
Swallow errors
alexpott Sep 2, 2020
244e8d2
Revert "Swallow errors"
alexpott Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Swallow errors
  • Loading branch information
@alexpott
alexpott committed Sep 2, 2020
commit ee8cc2666bc8d88c3b4236948f359cb78b5733d3
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function __construct($message, array $trace, $file)
$this->triggeringFile = $file;
if (isset($line['object']) || isset($line['class'])) {
set_error_handler(function () {});
$parsedMsg = unserialize($this->message);
$parsedMsg = @unserialize($this->message);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the `@ is not required anymore since the error handler ignores everything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in master - that's why I added it back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it here and submit a PR to clean up master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #38033 to address this in master.

restore_error_handler();
if ($parsedMsg && isset($parsedMsg['deprecation'])) {
$this->message = $parsedMsg['deprecation'];
Expand Down
0