10000 Remove unnecessary silence operator by alexpott · Pull Request #38033 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary silence operator #38033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

Remove unnecessary silence operator #38033

merged 1 commit into from
Sep 2, 2020

Conversation

alexpott
Copy link
Contributor
@alexpott alexpott commented Sep 2, 2020
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

A gobble-all-errors handler was added around the unserialize() call making the @ operator unnecessary.

@alexpott alexpott mentioned this pull request Sep 2, 2020
Merged
@xabbuh xabbuh added this to the next milestone Sep 2, 2020
@fabpot
Copy link
Member
fabpot commented Sep 2, 2020 •
edited
Loading

Merging in 4.4

@fabpot
Copy link
Member
fabpot commented Sep 2, 2020

Thank you @alexpott.

@fabpot fabpot merged commit dad4e95 into symfony:master Sep 2, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@alexpott @fabpot @nicolas-grekas @xabbuh @carsonbot
0