10000 [Lock] downgrade log.info to log.debug by rvitaliy · Pull Request #37713 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Lock] downgrade log.info to log.debug #37713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Aug 2, 2020
Merged

[Lock] downgrade log.info to log.debug #37713

merged 0 commits into from
Aug 2, 2020

Conversation

rvitaliy
Copy link
Contributor
Q A
Branch? master for features / 3.4, 4.4 or 5.1 for bug fixes
Bug fix? yes/no
New feature? no
Deprecations? no
Tickets Fix #37710
License MIT
Doc PR symfony/symfony-docs#...

we changed log behavior see issue for more details

@rvitaliy rvitaliy requested a review from jderusse as a code owner July 31, 2020 08:14
jderusse
jderusse approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member
@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shouldn't also downgrade the notice Failed to acquire the "{resource}" lock. Someone else already acquired the lock. to info

@fabpot
Copy link
Member
fabpot commented Jul 31, 2020

I agree with @jderusse
Can you also rebase as there is a conflict?

@nicolas-grekas nicolas-grekas changed the title refs #37710: [Lock] downgrade log.info to log.debug [Lock] downgrade log.info to log.debug Aug 1, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Aug 1, 2020
nicolas-grekas
nicolas-grekas approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.4, isn't it?

@fabpot
Copy link
Member
fabpot commented Aug 2, 2020

Thank you @rvitaliy.

@fabpot fabpot closed this Aug 2, 2020
@fabpot fabpot merged commit 6c021cb into symfony:master Aug 2, 2020
@rvitaliy rvitaliy deleted the fix/37710-lock-downgrade-log-info-to-log-debug branch August 4, 2020 10:54
@jderusse jderusse mentioned this pull request Aug 6, 2020
Merged
fabpot added a commit that referenced this pull request Aug 6, 2020
@fabpot
minor #37749 [Lock] downgrade log.info to log.debug (jderusse)
e1cfbd2 
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Lock] downgrade log.info to log.debug

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | ni
| Tickets       | /
| License       | MIT
| Doc PR        | /

This PR follows #37713 and reduce log verbosity in CombinedStore

Commits
-------

080f114 Reduce log verbosity for CombinedStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Bug Lock Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Lock] downgrade log.info to log.debug
5 participants
@rvitaliy @fabpot @nicolas-grekas @jderusse @carsonbot
0