You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #37749 [Lock] downgrade log.info to log.debug (jderusse)
This PR was merged into the 5.2-dev branch.
Discussion
----------
[Lock] downgrade log.info to log.debug
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| Deprecations? | ni
| Tickets | /
| License | MIT
| Doc PR | /
This PR follows #37713 and reduce log verbosity in CombinedStore
Commits
-------
080f114 Reduce log verbosity for CombinedStore
Copy file name to clipboardExpand all lines: src/Symfony/Component/Lock/Store/CombinedStore.php
+5-5Lines changed: 5 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -67,7 +67,7 @@ public function save(Key $key)
67
67
$store->save($key);
68
68
++$successCount;
69
69
} catch (\Exception$e) {
70
-
$this->logger->warning('One store failed to save the "{resource}" lock.', ['resource' => $key, 'store' => $store, 'exception' => $e]);
70
+
$this->logger->debug('One store failed to save the "{resource}" lock.', ['resource' => $key, 'store' => $store, 'exception' => $e]);
71
71
++$failureCount;
72
72
}
73
73
@@ -82,7 +82,7 @@ public function save(Key $key)
82
82
return;
83
83
}
84
84
85
-
$this->logger->warning('Failed to store the "{resource}" lock. Quorum has not been met.', ['resource' => $key, 'success' => $successCount, 'failure' => $failureCount]);
85
+
$this->logger->info('Failed to store the "{resource}" lock. Quorum has not been met.', ['resource' => $key, 'success' => $successCount, 'failure' => $failureCount]);
86
86
87
87
// clean up potential locks
88
88
$this->delete($key);
@@ -103,15 +103,15 @@ public function putOffExpiration(Key $key, float $ttl)
103
103
foreach ($this->storesas$store) {
104
104
try {
105
105
if (0.0 >= $adjustedTtl = $expireAt - microtime(true)) {
106
-
$this->logger->warning('Stores took to long to put off the expiration of the "{resource}" lock.', ['resource' => $key, 'store' => $store, 'ttl' => $ttl]);
106
+
$this->logger->debug('Stores took to long to put off the expiration of the "{resource}" lock.', ['resource' => $key, 'store' => $store, 'ttl' => $ttl]);
107
107
$key->reduceLifetime(0);
108
108
break;
109
109
}
110
110
111
111
$store->putOffExpiration($key, $adjustedTtl);
112
112
++$successCount;
113
113
} catch (\Exception$e) {
114
-
$this->logger->warning('One store failed to put off the expiration of the "{resource}" lock.', ['resource' => $key, 'store' => $store, 'exception' => $e]);
114
+
$this->logger->debug('One store failed to put off the expiration of the "{resource}" lock.', ['resource' => $key, 'store' => $store, 'exception' => $e]);
115
115
++$failureCount;
116
116
}
117
117
@@ -126,7 +126,7 @@ public function putOffExpiration(Key $key, float $ttl)
126
126
return;
127
127
}
128
128
129
-
$this->logger->warning('Failed to define the expiration for the "{resource}" lock. Quorum has not been met.', ['resource' => $key, 'success' => $successCount, 'failure' => $failureCount]);
129
+
$this->logger->notice('Failed to define the expiration for the "{resource}" lock. Quorum has not been met.', ['resource' => $key, 'success' => $successCount, 'failure' => $failureCount]);
0 commit comments