8000 [FrameworkBundle] Move session configuration to PHP by cocorambo · Pull Request #37217 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Move session configuration to PHP #37217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2020
Merged

[FrameworkBundle] Move session configuration to PHP #37217

merged 1 commit into from
Jun 12, 2020

Conversation

cocorambo
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37186
License MIT

Move session configuration file to php

yceruto
yceruto requested changes Jun 11, 2020
View reviewed changes
@yceruto
Copy link
Member
yceruto commented Jun 11, 2020

Please, check the fabbot report, there are other issues to solve: https://fabbot.io/report/symfony/symfony/37217/916dcec7c18845a635e11bb1bf796bbe426ab3f3

yceruto
yceruto approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member
@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simivar
Copy link
Contributor
simivar commented Jun 11, 2020

Shouldn't you remove old session.xml file?

Tobion
Tobion suggested changes Jun 11, 2020
View reviewed changes
@cocorambo cocorambo requested a review from Tobion June 12, 2020 13:53
@Tobion
Copy link
Contributor
Tobion commented Jun 12, 2020

Thank you @cocorambo.

@Tobion Tobion merged commit f5310ce into symfony:master Jun 12, 2020
@rvanlaak
Copy link
Contributor

@Tobion merging this PR did close #37186 because of the description.

FYI same would happen for #37204 , #37208 and #37222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion approved these changes

@simivar simivar simivar approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move internal Container configuration from XML to PHP
6 participants
@cocorambo @yceruto @simivar @Tobion @rvanlaak @carsonbot
0