[FrameworkBundle] Move mailer configuration to php #37204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instabledesign
commented
Jun 11, 2020
|
|
||
| ->set('mailer.transport_factory.smtp', EsmtpTransportFactory::class) | ||
| ->parent('mailer.transport_factory.abstract') | ||
| ->tag('mailer.transport_factory', ['priority' => -100]) |
There was a problem hiding this comment.
should i set string or int value for the priority attribute?
instabledesign
commented
Jun 11, 2020
Tobion
suggested changes
Jun 13, 2020
| ->set('mailer.transports', Transports::class) | ||
| ->factory([service('mailer.transport_factory'), 'fromStrings']) | ||
| ->args([ | ||
| [], //transports |
There was a problem hiding this comment.
abstract_arg please as an empty array is not valid
| ]) | ||
|
|
||
| ->set('mailer.transport_factory', Transport::class) | ||
| ->args([tagged_iterator('mailer.transport_factory')]) |
There was a problem hiding this comment.
please use multi-line args consistently everywhere
| ]) | ||
| ->tag('data_collector', [ | ||
| 'id' => 'mailer', | ||
| 'template' => '@WebProfiler/Collector/mailer.html.twig', |
There was a problem hiding this comment.
please change the order of template and id to be consistent with the other data_collector tags
|
Fixup done |
Tobion
approved these changes
Jun 15, 2020
3c70354 to
eb88f88
Compare
|
Thank you @instabledesign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move mailer configuration file to php