8000 [Cache][Lock][Messenger] Don't execute tests with DBAL 2.x on php 8 by derrabus · Pull Request #36927 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache][Lock][Messenger] Don't execute tests with DBAL 2.x on php 8 #36927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

[Cache][Lock][Messenger] Don't execute tests with DBAL 2.x on php 8 #36927

merged 1 commit into from
May 23, 2020

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented May 23, 2020 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

Follow-up to #36895: If we autoload the PDOConnection from DBAL 2.x during a test on php8, our test suite goes 💥

What this PR does:

  • Some more Cache tests are skipped if DBAL 2 is installed on php 8.
  • The Lock and Messenger components are tested against DBAL 3.

@derrabus derrabus requested review from jderusse and sroze as code owners May 23, 2020 15:28
@derrabus derrabus force-pushed the bugfix/skip-dbal2-on-php8 branch from 9a413bd to 7dc3f9c Compare May 23, 2020 15:32
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 23, 2020
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 098d84a into symfony:4.4 May 23, 2020
@derrabus derrabus deleted the bugfix/skip-dbal2-on-php8 branch May 23, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Cache Lock Messenger Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0