Skip Doctrine DBAL on php 8 until we have a compatible version #36895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05ba2a7 to
a6abee6
Compare
nicolas-grekas
approved these changes
May 22, 2020
There shouldn't be much to do on our side. We might be compatible as soon as the ORM is compatible. |
does this mean we can make |
|
I'll look into this. |
a6abee6 to
c579db6
Compare
|
The cache testsuite passes with DBAL 3 on php 8. |
c579db6 to
1090738
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2020
….x on php 8 (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [Cache][Lock][Messenger] Don't execute tests with DBAL 2.x on php 8 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A Follow-up to #36895: If we autoload the `PDOConnection` from DBAL 2.x during a test on php8, our test suite goes 💥 What this PR does: * Some more Cache tests are skipped if DBAL 2 is installed on php 8. * The Lock and Messenger components are tested against DBAL 3. Commits ------- 7dc3f9c Don't execute tests with DBAL 2.x on php 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips all tests on php 8 that would trigger an autoload on DBAL's
PDOConnection. Those tests would exit with a fatal error because of incompatible method signatures (see doctrine/dbal#3791) and until we can test against a compatible version of DBAL, there's (at least from my point of view) nothing we can do about it. Once this issue is resolved, we can revert this change.