8000 [MonologBridge] Fix $level type by Seldaek · Pull Request #36334 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] Fix $level type #36334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2020
Merged

[MonologBridge] Fix $level type #36334

merged 1 commit into from
Apr 4, 2020

Conversation

Seldaek
Copy link
Member
@Seldaek Seldaek commented Apr 3, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT

Monolog accepts both level names like 'info' or int constants. The parent constructor will normalize it to an int. https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/AbstractHandler.php#L53

Note that this may need to be applied on more handlers here I did not check, if someone feels like going over them all please feel free.

fancyweb
fancyweb approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor
@fancyweb fancyweb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are indeed more changes to do but on 4.4 and 5.0. This PR is the one for master. I'll take care of them.

This was referenced Apr 3, 2020
Merged
Merged
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 3, 2020
@nicolas-grekas nicolas-grekas changed the title Fix $level type [MonologBridge] Fix $level type Apr 3, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Apr 3, 2020
fabpot added a commit that referenced this pull request Apr 4, 2020
@fabpot
bug #36337 [4.4][MonologBridge] Fix $level type (fancyweb)
718722d 
This PR was merged into the 4.4 branch.

Discussion
----------

[4.4][MonologBridge] Fix $level type

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36334 (comment)
| License       | MIT
| Doc PR        | -

Commits
-------

19a8905 [4.4][MonologBridge] Fix $level type
@fabpot
Copy link
Member
fabpot commented Apr 4, 2020

Thank you @Seldaek.

@fabpot fabpot merged commit ba52c62 into symfony:master Apr 4, 2020
fabpot added a commit that referenced this pull request Apr 4, 2020
@fabpot
bug #36338 [5.0][MonologBridge] Fix $level type (fancyweb)
e0c1ee6 
This PR was merged into the 5.0 branch.

Discussion
----------

[5.0][MonologBridge] Fix $level type

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36334 (comment)
| License       | MIT
| Doc PR        | -

Commits
-------

d9c0681 [5.0][MonologBridge] Fix $level type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Seldaek @fabpot @fancyweb @nicolas-grekas @carsonbot
0