bug #36334 [MonologBridge] Fix $level type (Seldaek)

fabpot · fabpot · commit ba52c62516d1 · 2020-04-04T09:13:18.000+02:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [MonologBridge] Fix $level type | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT Monolog accepts both level names like 'info' or int constants. The parent constructor will normalize it to an int. https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/AbstractHandler.php#L53 Note that this may need to be applied on more handlers here I did not check, if someone feels like going over them all please feel free. Commits ------- c2a1781 Fix $level type
diff --git a/src/Symfony/Bridge/Monolog/Handler/MailerHandler.php b/src/Symfony/Bridge/Monolog/Handler/MailerHandler.php
@@ -30,8 +30,9 @@ class MailerHandler extends AbstractProcessingHandler
 
     /**
      * @param callable|Email $messageTemplate
+     * @param string|int     $level           The minimum logging level at which this handler will be triggered
      */
-    public function __construct(MailerInterface $mailer, $messageTemplate, int $level = Logger::DEBUG, bool $bubble = true)
+    public function __construct(MailerInterface $mailer, $messageTemplate, $level = Logger::DEBUG, bool $bubble = true)
     {
         parent::__construct($level, $bubble);
 

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,9 @@ class MailerHandler extends AbstractProcessingHandler`
`30`	`30`
`31`	`31`	`/**`
`32`	`32`	`* @param callable\|Email $messageTemplate`
	`33`	`+ * @param string\|int $level The minimum logging level at which this handler will be triggered`
`33`	`34`	`*/`
`34`		`- public function __construct(MailerInterface $mailer, $messageTemplate, int $level = Logger::DEBUG, bool $bubble = true)`
	`35`	`+ public function __construct(MailerInterface $mailer, $messageTemplate, $level = Logger::DEBUG, bool $bubble = true)`
`35`	`36`	`{`
`36`	`37`	`parent::__construct($level, $bubble);`
`37`	`38`