8000 [Routing] Add installation and minimal example to README by wouterj · Pull Request #36246 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Add installation and minimal example to README #36246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2020
Merged

[Routing] Add installation and minimal example to README #36246

merged 1 commit into from
Apr 4, 2020

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Mar 27, 2020
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR symfony/symfony-docs#13431

Similair to what I did in #35552, this PR updates the README of the Routing component to include a minimal example and installation command.

Tobion
Tobion reviewed Mar 27, 2020
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Mar 28, 2020
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Mar 31, 2020 •
edited
Loading

I was wondering about CompiledUrlMatcher. It's mentioned on create_framework/routing.rst, but https://symfony.com/doc/current/routing.html doesn't link to it, isn't it? Is this something that needs to be improved?

@fabpot
Copy link
Member
fabpot commented Apr 4, 2020

I think this is good enough.

@fabpot
Copy link
Member
fabpot commented Apr 4, 2020

Thank you @wouterj.

@fabpot fabpot merged commit d33392f into symfony:4.4 Apr 4, 2020
@wouterj wouterj deleted the readme/routing branch April 4, 2020 13:02
@wouterj wouterj mentioned this pull request Apr 4, 2020
Merged
wouterj added a commit to symfony/symfony-docs that referenced this pull request Apr 4, 2020
@wouterj
minor #13431 Removed Routing component docs (wouterj)
c4a2178 
This PR was merged into the 4.4 branch.

Discussion
----------

Removed Routing component docs

Turns out we already did a good job in removing all framework-usage information to the main Routing guide. I've moved the first example to the Routing component README (symfony/symfony#36246).

This means we're loosing some information on file loaders and the all-in-one router, but I don't think that matters much (the component is small enough to follow what's happening while looking at the source code).

Commits
-------

11ea50e Removed Routing component docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @nicolas-grekas @fabpot @Tobion @carsonbot
0