-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Translation][Debug] Add installation and minimal example to README #35552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for taking care of this Wouter.
xabbuh
approved these changes
Feb 1, 2020
94noni
reviewed
Feb 2, 2020
94noni
reviewed
Feb 2, 2020
yceruto
approved these changes
Feb 2, 2020
dunglas
approved these changes
Feb 3, 2020
noniagriconomie
approved these changes
Feb 3, 2020
fabpot
approved these changes
Feb 3, 2020
5177a9a
to
b52b7b9
Compare
Thank you @wouterj. |
8000
fabpot
added a commit
that referenced
this pull request
Feb 3, 2020
…e to README (wouterj) This PR was squashed before being merged into the 3.4 branch (closes #35552). Discussion ---------- [Translation][Debug] Add installation and minimal example to README | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | - At SymfonyCon, we decided to test out removing some component documentation from the official docs. These were duplicating quite some information of the main guides and were confusing people that used the components in the framework. I think it's good to reintroduced the composer installation command and a very minimal example in the README's of the component. This doesn't require maintenance and can kickstart people to gain knowledge on how to use the component. For now, we've (re)moved the Debug and Translation component docs, so that's why I've only modified those README's. cc @symfony/team-symfony-docs Commits ------- b52b7b9 [Translation][Debug] Add installation and minimal example to README
This was referenced Mar 27, 2020
fabpot
added a commit
that referenced
this pull request
Apr 4, 2020
… (wouterj) This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Add installation and minimal example to README | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#13431 Similair to what I did in #35552, this PR updates the README of the Routing component to include a minimal example and installation command. Commits ------- be66120 Add installation and minimal example to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At SymfonyCon, we decided to test out removing some component documentation from the official docs. These were duplicating quite some information of the main guides and were confusing people that used the components in the framework.
I think it's good to reintroduced the composer installation command and a very minimal example in the README's of the component. This doesn't require maintenance and can kickstart people to gain knowledge on how to use the component.
For now, we've (re)moved the Debug and Translation component docs, so that's why I've only modified those README's.
cc @symfony/team-symfony-docs