8000 fix links to releases page (formerly known as "roadmap") by garak · Pull Request #35703 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

fix links to releases page (formerly known as "roadmap") #35703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

garak
Copy link
Contributor
@garak garak commented Feb 13, 2020
Q A
Branch? 3.4
Bug fix? kind of
New feature? no
Deprecations? no
Tickets none
License MIT
Doc PR none

Current releases page is https://symfony.com/releases
Formerly it was https://symfony.com/roadmap and there's a nice redirect to new URL.
Anyway, I think that pointing to the right new URL would be better

@@ -202,7 +202,7 @@
<td class="font-normal">{{ collector.symfonyeom }}</td>
<td class="font-normal">{{ collector.symfonyeol }}</td>
<td class="font-normal">
<a href="https://symfony.com/roadmap?version={{ collector.symfonyminorversion }}#checker">View roadmap</a>
<a href="https://symfony.com/releases?version={{ collector.symfonyminorversion }}#checker">View roadmap</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified further like this:

https://symfony.com/releases/{{ collector.symfonyminorversion }}

@fabpot
Copy link
Member
fabpot commented Feb 13, 2020

Thank you @garak.

fabpot added a commit that referenced this pull request Feb 13, 2020
… (garak)

This PR was merged into the 3.4 branch.

Discussion
----------

fix links to releases page (formerly known as "roadmap")

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | kind of
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | none

Current releases page is https://symfony.com/releases
Formerly it was https://symfony.com/roadmap and there's a nice redirect to new URL.
Anyway, I think that pointing to the right new URL would be better

Commits
-------

1c8fbe1 fix links to releases page (formerly known as "roadmap")
@fabpot fabpot merged commit 1c8fbe1 into symfony:3.4 Feb 13, 2020
@garak
Copy link
Contributor Author
garak commented Feb 13, 2020

@fabpot can you re-open? I spotted a change to do in anchor

fabpot added a commit that referenced this pull request Feb 13, 2020
This PR was merged into the 3.4 branch.

Discussion
----------

fix anchor

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | none

This is a continuation of PR #35703 that was merged a bit too early.
It accepts suggestion made there and, moreover, fixes anchor link (that changed from old roadmap page)

Commits
-------

5825e3c fix anchor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0