[WIP][Security]replaced acl:init command with postGenerateSchema listener #3560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Mar 11, 2012
Commits ------- 6d27aec [SecurityBundle] Improve the init:acl command e809458 [Security]replaced acl:init command with postGenerateSchema listener Discussion ---------- [WIP][Security]replaced acl:init command with postGenerateSchema listener Attempt to fix #2091. The code is from @schmittjoh (see #1313) but was never merged. The difference is that the `init:acl` command has not been dropped in order to overcome [the limitations](#1313 (comment)) described by @stof. @stof do you think this is ok ? Left to fix: * Using the code from this PR, the generated migration does not drop the tables but still alter them, @stof you know this part of the code far better than me. I would appreacite your feedback on this PR and any hint on solving the remaining item. Thanks.
| @@ -89,7 +89,11 @@ private function addAclSection(ArrayNodeDefinition $rootNode) | |||
| ->children() | |||
| ->arrayNode('acl') | |||
| ->children() | |||
| ->scalarNode('connection')->setInfo('any name configured in doctrine.dbal section')->end() | |||
| ->scalarNode('connection') | |||
| ->defaultValue('default') | |||
There was a problem hiding this comment.
the default value should be null to mean the default connection IMO. Nothing enforces to have a connection named default (and this is a regression as it was handled properly before)
fabpot
added a commit
that referenced
this pull request
Mar 12, 2012
wouterj
pushed a commit
to wouterj/DoctrinePHPCRBundle
that referenced
this pull request
May 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #2091.
The code is from @schmittjoh (see #1313) but was never merged.
The difference is that the
init:aclcommand has not been dropped in order to overcome the limitations described by @stof. @stof do you think this is ok ?Left to fix:
@stof you know this part of the code far better than me. I would appreacite your feedback on this PR and any hint on solving the remaining item. Thanks.