Fix unsigned columns in MySql #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsigned column properties were never set. In consequence all migrations diff were trying to change the column definition when it was already changed.
guilhermeblanco
added a commit
that referenced
this pull request
Aug 8, 2012
Fix unsigned columns in MySql
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 4, 2012
Commits ------- 1b5ad17 Revert "Removed MySQL-exclusive usage of unsigned integer from table creation" Discussion ---------- [Security][DBAL] Revert MySQL unsigned removal Revert "Removed MySQL-exclusive usage of unsigned integer from table creation" This reverts commit 57694aa. The problem is underlying in Doctrine DBAL change tracking and should either be fixed or ignored there. I opened a ticket on Doctrine Jira http://doctrine-project.org/jira/browse/DBAL-322 --------------------------------------------------------------------------- by fabpot at 2012-08-14T06:40:47Z I will merge this PR after we have a release of DBAL that includes the fix for DBAL-322. --------------------------------------------------------------------------- by acasademont at 2012-08-20T08:01:48Z This was already fixed 2 weeks ago in doctrine/dbal#183 so i guess this can be closed --------------------------------------------------------------------------- by acasademont at 2012-08-20T08:02:06Z merged i mean
fabpot
added a commit
to symfony/security
that referenced
this pull request
Sep 4, 2012
Commits ------- 1b5ad17 Revert "Removed MySQL-exclusive usage of unsigned integer from table creation" Discussion ---------- [Security][DBAL] Revert MySQL unsigned removal Revert "Removed MySQL-exclusive usage of unsigned integer from table creation" This reverts commit 57694aaa94ec0118f516e8962be2f018c36d2011. The problem is underlying in Doctrine DBAL change tracking and should either be fixed or ignor 74A0 ed there. I opened a ticket on Doctrine Jira http://doctrine-project.org/jira/browse/DBAL-322 --------------------------------------------------------------------------- by fabpot at 2012-08-14T06:40:47Z I will merge this PR after we have a release of DBAL that includes the fix for DBAL-322. --------------------------------------------------------------------------- by acasademont at 2012-08-20T08:01:48Z This was already fixed 2 weeks ago in doctrine/dbal#183 so i guess this can be closed --------------------------------------------------------------------------- by acasademont at 2012-08-20T08:02:06Z merged i mean
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsigned column properties were never set. In consequence all migrations diff were trying to change the column definition when it was already changed. See symfony/symfony#3560
Would it be also nice to add some test to avoid regressions, but i don't know where it would be a nice place to put them.