10000 [Messenger] Fix bug when using single route with XML config by Nyholm · Pull Request #35502 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Fix bug when using single route with XML config #35502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

[Messenger] Fix bug when using single route with XML config #35502

merged 1 commit into from
Jan 29, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Jan 28, 2020
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35500
License MIT
Doc PR

When using just a single routing attribute with XML then the sky falls down.

This small change make sure everything works as expected.

@Nyholm Nyholm mentioned this pull request Jan 28, 2020
Closed
@fabpot fabpot force-pushed the issue-35500-messenger-xml-4.4 branch from 381b004 to a2a606e Compare January 29, 2020 10:50
@fabpot
Copy link
Member
fabpot commented Jan 29, 2020

Thank you @Nyholm.

fabpot added a commit that referenced this pull request Jan 29, 2020
@fabpot
bug #35502 [Messenger] Fix bug when using single route with XML confi…
c573787 
…g (Nyholm)

This PR was squashed before being merged into the 4.4 branch (closes #35502).

Discussion
----------

[Messenger] Fix bug when using single route with XML config

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35500
| License       | MIT
| Doc PR        |

When using just a single routing attribute with XML then the sky falls down.

This small change make sure everything works as expected.

Commits
-------

a2a606e [Messenger] Fix bug when using single route with XML config
@fabpot fabpot merged commit a2a606e into symfony:4.4 Jan 29, 2020
< AF1F /div>
@Nyholm Nyholm deleted the issue-35500-messenger-xml-4.4 branch January 29, 2020 11:03
@Nyholm
Copy link
Member Author
Nyholm commented Jan 29, 2020

Thank you for merging

@Koc Koc mentioned this pull request Jan 31, 2020
Closed
This was referenced Jan 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @fabpot @dunglas @carsonbot
0