8000 [WIP][Messenger][FrameworkBundle] Fix xml configuration of messenger routing by Koc · Pull Request #33750 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WIP][Messenger][FrameworkBundle] Fix xml configuration of messenger routing #33750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP][Messenger][FrameworkBundle] Fix xml configuration of messenger routing #33750

wants to merge 1 commit into from

Conversation

Koc
Copy link
Contributor
@Koc Koc commented Sep 28, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Follow up of #31710
License MIT
Doc PR -

@Koc
Copy link
Contributor Author
Koc commented Sep 28, 2019

"feature" and "deprecation" labels added by mistake.

@Koc Koc mentioned this pull request Sep 28, 2019
Merged
@Koc Koc force-pushed the bugfix/fix-messenger-routing-xml-config branch from 032c2da to a38953b Compare September 28, 2019 21:57
@Koc Koc changed the title [Messenger][FrameworkBundle] Fix xml configuration of messenger routing [WIP][Messenger][FrameworkBundle] Fix xml configuration of messenger routing Sep 28, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 29, 2019
@nicolas-grekas
Copy link
Member

Tests fail apparently.

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
@weaverryan
Copy link
Member

Ping @Koc! Is this one done or almost done? Thx :)

@Nyholm
Copy link
Member
Nyholm commented Jan 19, 2020

Friendly ping

@Koc
Copy link
Contributor Author
Koc commented Jan 31, 2020

Fixed by @Nyholm in #35502 .

BTW, anybody knows, why fixXmlConfig not help in this case?

@Koc Koc closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Messenger Status: Needs Review
4BB9
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Koc @nicolas-grekas @weaverryan @Nyholm @carsonbot
0