10000 Sort the KernelEvents constants to match the lifecycle of the framework by hermann8u · Pull Request #35440 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Sort the KernelEvents constants to match the lifecycle of the framework #35440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Sort the KernelEvents constants to match the lifecycle of the framework #35440

merged 1 commit into from
Jan 30, 2020

Conversation

hermann8u
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This PR is the same as #35248 but on the correct branch this time!

Hi,

When I need to visualize all the kernel events I often open the KernelEvents file. However, it is difficult to navigate through it because the constants are not in the same order compared to the framework execution life cycle.

This PR aims to sort this constants to match it. It's also the same order used in this documentation page.

Thanks.

@OskarStark
Copy link
Contributor

Maybe mention the sorting in the class phpdoc?

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 22, 2020
@hermann8u
Copy link
Contributor Author

Could you be more precise please?

@OskarStark
Copy link
Contributor

Could you be more precise please?

Sure. What I mean is to adjust the class description like this:

- Contains all events thrown in the HttpKernel component.
+ Contains all events (sorted by their lifecycle) thrown in the HttpKernel component.

sth like this...

stof
stof reviewed Jan 24, 2020
View reviewed changes
@fabpot fabpot force-pushed the sort-kernel-events branch from 1814a41 to a447cba Compare January 30, 2020 13:39
@fabpot
Copy link
Member
fabpot commented Jan 30, 2020

Thank you @hermann8u.

@fabpot fabpot closed this in e493752 Jan 30, 2020
@fabpot fabpot merged commit a447cba into symfony:master Jan 30, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@hermann8u @OskarStark @fabpot @nicolas-grekas @stof @carsonbot
0