minor #35440 Sort the KernelEvents constants to match the lifecycle of the framework (hermann8u)

fabpot · fabpot · commit e4937523e6e7 · 2020-01-30T14:39:36.000+01:00
This PR was squashed before being merged into the 5.1-dev branch (closes #35440). Discussion ---------- Sort the KernelEvents constants to match the lifecycle of the framework | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | - | License | MIT | Doc PR | - This PR is the same as #35248 but on the correct branch this time! > Hi, > > When I need to visualize all the kernel events I often open the KernelEvents file. However, it is difficult to navigate through it because the constants are not in the same order compared to the framework execution life cycle. > > This PR aims to sort this constants to match it. It's also the same order used in [this documentation page](https://symfony.com/doc/current/reference/events.html). > > Thanks. Commits ------- a447cba Sort the KernelEvents constants to match the lifecycle of the framework
diff --git a/src/Symfony/Component/HttpKernel/KernelEvents.php b/src/Symfony/Component/HttpKernel/KernelEvents.php
@@ -39,17 +39,6 @@ final class KernelEvents
      */
     const EXCEPTION = 'kernel.exception';
 
-    /**
-     * The VIEW event occurs when the return value of a controller
-     * is not a Response instance.
-     *
-     * This event allows you to create a response for the return value of the
-     * controller.
-     *
-     * @Event("Symfony\Component\HttpKernel\Event\ViewEvent")
-     */
-    const VIEW = 'kernel.view';
-
     /**
      * The CONTROLLER event occurs once a controller was found for
      * handling a request.
@@ -71,6 +60,17 @@ final class KernelEvents
      */
     const CONTROLLER_ARGUMENTS = 'kernel.controller_arguments';
 
+    /**
+     * The VIEW event occurs when the return value of a controller
+     * is not a Response instance.
+     *
+     * This event allows you to create a response for the return value of the
+     * controller.
+     *
+     * @Event("Symfony\Component\HttpKernel\Event\ViewEvent")
+     */
+    const VIEW = 'kernel.view';
+
     /**
      * The RESPONSE event occurs once a response was created for
      * replying to a request.
@@ -82,15 +82,6 @@ final class KernelEvents
      */
     const RESPONSE = 'kernel.response';
 
-    /**
-     * The TERMINATE event occurs once a response was sent.
-     *
-     * This event allows you to run expensive post-response jobs.
-     *
-     * @Event("Symfony\Component\HttpKernel\Event\TerminateEvent")
-     */
-    const TERMINATE = 'kernel.terminate';
-
     /**
      * The FINISH_REQUEST event occurs when a response was generated for a request.
      *
@@ -100,4 +91,13 @@ final class KernelEvents
      * @Event("Symfony\Component\HttpKernel\Event\FinishRequestEvent")
      */
     const FINISH_REQUEST = 'kernel.finish_request';
+
+    /**
+     * The TERMINATE event occurs once a response was sent.
+     *
+     * This event allows you to run expensive post-response jobs.
+     *
+     * @Event("Symfony\Component\HttpKernel\Event\TerminateEvent")
+     */
+    const TERMINATE = 'kernel.terminate';
 }
