[HttpKernel] Sort the KernelEvents constants #35248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is not a bug fix, it should be done on master. |
nicolas-grekas
approved these changes
Jan 7, 2020
|
Is this ok finally on 3.4 branch or should I rebase? Moreover, be aware that there will be a merge conflict for branch >= 4.3 because the event class in annotations @event changed. |
|
I didn't change my mind. That's for master. |
|
@hermann8u can you please resubmit for master? |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2020
…f the framework (hermann8u) This PR was squashed before being merged into the 5.1-dev branch (closes #35440). Discussion ---------- Sort the KernelEvents constants to match the lifecycle of the framework | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | - This PR is the same as #35248 but on the correct branch this time! > Hi, > > When I need to visualize all the kernel events I often open the KernelEvents file. However, it is difficult to navigate through it because the constants are not in the same order compared to the framework execution life cycle. > > This PR aims to sort this constants to match it. It's also the same order used in [this documentation page](https://symfony.com/doc/current/reference/events.html). > > Thanks. Commits ------- a447cba Sort the KernelEvents constants to match the lifecycle of the framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I need to visualize all the kernel events I often open the KernelEvents file. However, it is difficult to navigate through it because the constants are not in the same order compared to the framework execution life cycle.
This PR aims to sort this constants to match it. It's also the same order used in this documentation page.
Thanks.