8000 [Console] Fix filtering out identical alternatives when there is a command loader by fancyweb · Pull Request #35094 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Fix filtering out identical alternatives when there is a command loader #35094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2019
Merged

[Console] Fix filtering out identical alternatives when there is a command loader #35094

merged 1 commit into from
Dec 24, 2019

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Dec 23, 2019 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #35089
License MIT
Doc PR -

CommandLoader commands needs to be loaded to resolve their names and filter them.

@chalasr chalasr added this to the 3.4 milestone Dec 23, 2019
chalasr
chalasr requested changes Dec 24, 2019
View reviewed changes
@fancyweb fancyweb force-pushed the console-console-loader-filter-alias branch from d59cc1b to 526a875 Compare December 24, 2019 11:07
@fancyweb fancyweb force-pushed the console-console-loader-filter-alias branch from 526a875 to 589e93e Compare December 24, 2019 11:07
chalasr
chalasr approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chalasr
Copy link
Member
chalasr commented Dec 24, 2019

Good catch, thanks @fancyweb.

chalasr added a commit that referenced this pull request Dec 24, 2019
@chalasr
bug #35094 [Console] Fix filtering out identical alternatives when th…
1908434 
…ere is a command loader (fancyweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix filtering out identical alternatives when there is a command loader

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35089
| License       | MIT
| Doc PR        | -

CommandLoader commands needs to be loaded to resolve their names and filter them.

Commits
-------

589e93e [Console] Fix filtering out identical alternatives when there is a command loader
@chalasr chalasr merged commit 589e93e into symfony:3.4 Dec 24, 2019
@fancyweb fancyweb deleted the console-console-loader-filter-alias branch December 26, 2019 08:59
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
@lutzpetzoldt
Copy link

After updating from 4.3.9 to 4.3.10 this change leads to loading of lazy commands even if they are not called. This occurs with commands where the first part of the name matches. For example if you have two lazy commands app:foo and app:foo:bar, and call app:foo, then app:foo:bar will also be instantiated, although it is not called. This should not happen according to the documentation (link). I think the problem is line 668 in Application.php. Can you please confirm this behavior? Should I create a new issue?

@fancyweb
Copy link
Contributor Author

Hello, please create a new issue with a reproducer so someone can check it and start working on a fix if there was a regression. Thanks 😃

@lutzpetzoldt lutzpetzoldt mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @chalasr @lutzpetzoldt @carsonbot
0