8000 [Console] identical alternatives shouldn't be considered ambiguous · Issue #35089 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] identical alternatives shouldn't be considered ambiguous #35089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zorn-v opened this issue Dec 23, 2019 · 3 comments
Closed

[Console] identical alternatives shouldn't be considered ambiguous #35089

zorn-v opened this issue Dec 23, 2019 · 3 comments
Labels
Bug Console Status: Needs Review

Comments

@zorn-v
Copy link
zorn-v commented Dec 23, 2019 •
edited
Loading

symfony/messenger 4.4
изображение
изображение
изображение

symfony/messenger 5.0
изображение
изображение
@nicolas-grekas
Copy link
Member

Looks like we could collapse multiple identical alternatives and skip the ambiguity.
I'm reclassifying this issue as a feature request on the Console component.
@zorn-v up for a PR?

@nicolas-grekas nicolas-grekas changed the title [messenger] Deprecation is a LIE [Console] identical alternatives shouln't be considered ambiguous Dec 23, 2019
@nicolas-grekas nicolas-grekas changed the title [Console] identical alternatives shouln't be considered ambiguous [Console] identical alternatives shouldn't be considered ambiguous Dec 23, 2019
@fancyweb
Copy link
Contributor

The messenger:consume-messages command was removed in Symfony 5.0. I cannot reproduce the original issue of still having this command in 5.0.

@fancyweb fancyweb mentioned this issue Dec 23, 2019
Merged
@zorn-v
Copy link
Author
zorn-v commented Dec 24, 2019

Yep, my fault. Deprecated command removed from symfony/console component, not symfony/messenger. But issue was not useless anyway 😄

chalasr added a commit that referenced this issue Dec 24, 2019
@chalasr
bug #35094 [Console] Fix filtering out identical alternatives when th…
1908434 
…ere is a command loader (fancyweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix filtering out identical alternatives when there is a command loader

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35089
| License       | MIT
| Doc PR        | -

CommandLoader commands needs to be loaded to resolve their names and filter them.

Commits
-------

589e93e [Console] Fix filtering out identical alternatives when there is a command loader
@chalasr chalasr closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nicolas-grekas @xabbuh @fancyweb @chalasr @zorn-v @carsonbot
0