10000 [DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable by fancyweb · Pull Request #35067 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable #35067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2019
Merged

[DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable #35067

merged 1 commit into from
Dec 26, 2019

Conversation

fancyweb
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #35066
License MIT
Doc PR -

@chalasr chalasr added this to the 4.4 milestone Dec 23, 2019
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Dec 26, 2019 •
edited
Loading

I'd suggest opening a bug report on https://bugs.php.net
method_exists('Closure', '__invoke') should return true to me, since we can call the method
https://3v4l.org/NEK2T

@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Dec 26, 2019
@nicolas-grekas
bug #35067 [DependencyInjection][CheckTypeDeclarationsPass] Handle \C…
aac9ca2 
…losure for callable (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35066
| License       | MIT
| Doc PR        | -

Commits
-------

d6a7fbf [DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable
@nicolas-grekas nicolas-grekas merged commit d6a7fbf into symfony:4.4 Dec 26, 2019
@fancyweb fancyweb deleted the di-container-lint-callable-closure branch December 26, 2019 08:59
@fancyweb fancyweb mentioned this pull request Dec 26, 2019
Closed
This was referenced Jan 21, 2020
Merged
Merged
@xabbuh xabbuh mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @chalasr 3270 @carsonbot
0