8000 lint:container handles callable arguments incorrectly · Issue #35066 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

lint:container handles callable arguments incorrectly #35066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tetragramat opened this issue Dec 20, 2019 · 1 comment
Closed

lint:container handles callable arguments incorrectly #35066

Tetragramat opened this issue Dec 20, 2019 · 1 comment
Labels
Bug DependencyInjection Status: Needs Review

Comments

@Tetragramat
Copy link
Contributor

Symfony version(s) affected: 4.4.2

Description
lint:container handles callable arguments incorrectly

In CheckTypeDeclarationsPass.php line 185:
                                                                                                                                                 
  Invalid definition for service ".3_HandlerStack~SOtgqKJ": argument 1 of "GuzzleHttp\HandlerStack::push" accepts "callable", "Closure" passed.

Callable should allow closure as passed argument.

see https://3v4l.org/WTHY4
@fancyweb fancyweb mentioned this issue Dec 20, 2019
Merged
nicolas-grekas added a commit that referenced this issue Dec 26, 2019
@nicolas-grekas
bug #35067 [DependencyInjection][CheckTypeDeclarationsPass] Handle \C…
aac9ca2 
…losure for callable (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #35066
| License       | MIT
| Doc PR        | -

Commits
-------

d6a7fbf [DependencyInjection][CheckTypeDeclarationsPass] Handle \Closure for callable
@fancyweb
Copy link
Contributor

This can be closed as #35067 was merged.

@xabbuh xabbuh mentioned this issue Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @nicolas-grekas @fancyweb @Tetragramat @carsonbot
0