8000 [Validator] Label regex in date validator by kristofvc · Pull Request #34705 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Label regex in date validator #34705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2019
Merged

[Validator] Label regex in date validator #34705

merged 1 commit into from
Nov 30, 2019

Conversation

kristofvc
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets /
License MIT
Doc PR

This change makes sure that when extending the DateValidator you can easily change the format withouth changing anything else.
eg. you can change the pattern to
/^(?<day>\d{2})/(?<month>\d{2})/(?<year>\d{4})$/ but the implementation still checks your date correctly.

@kristofvc kristofvc force-pushed the labeled-date-validator branch from 76b31fe to 23cb7fc Compare November 29, 2019 10:27
@nicolas-grekas nicolas-grekas added this to the next milestone Nov 29, 2019
nicolas-grekas
nicolas-grekas reviewed Nov 29, 2019
View reviewed changes
@kristofvc kristofvc force-pushed the labeled-date-validator branch from 23cb7fc to ec09f7e Compare November 29, 2019 20:05
@fabpot
Copy link
Member
fabpot commented Nov 30, 2019

Thank you @kristofvc.

@fabpot fabpot mentioned this pull request Nov 30, 2019
Closed
fabpot added a commit that referenced this pull request Nov 30, 2019
@fabpot
feature #34705 [Validator] Label regex in date validator (kristofvc)
270247a 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Validator] Label regex in date validator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        |

This change makes sure that when extending the DateValidator you can easily change the format withouth changing anything else.
eg. you can change the pattern to
`/^(?<day>\d{2})/(?<month>\d{2})/(?<year>\d{4})$/` but the implementation still checks your date correctly.

Commits
-------

ec09f7e Label regex in date validator
@fabpot fabpot merged commit ec09f7e into symfony:master Nov 30, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Validator
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kristofvc @fabpot @nicolas-grekas @carsonbot
0