Label regex in date validator

kristofvc · kristofvc · commit 23cb7fc3a810 · 2019-11-29T11:26:56.000+01:00
diff --git a/UPGRADE-5.1.md b/UPGRADE-5.1.md
@@ -11,3 +11,8 @@ Routing
 -------
 
  * Deprecated `RouteCollectionBuilder` in favor of `RoutingConfigurator`.
+
+Validator
+---------
+
+ * When extending `DateValidator`, if you override the pattern, make sure you label your regex with day, month and year.
diff --git a/src/Symfony/Component/Validator/Constraints/DateValidator.php b/src/Symfony/Component/Validator/Constraints/DateValidator.php
@@ -21,7 +21,7 @@
  */
 class DateValidator extends ConstraintValidator
 {
-    const PATTERN = '/^(\d{4})-(\d{2})-(\d{2})$/';
+    const PATTERN = '/^(?<year>\d{4})-(?<month>\d{2})-(?<day>\d{2})$/';
 
     /**
      * Checks whether a date is valid.
@@ -61,7 +61,9 @@ public function validate($value, Constraint $constraint)
             return;
         }
 
-        if (!self::checkDate($matches[1], $matches[2], $matches[3])) {
+        if (!isset($matches['year'], $matches['month'], $matches['day'])
+            || !self::checkDate($matches['year'], $matches['month'], $matches['day'])
+        ) {
             $this->context->buildViolation($constraint->message)
                 ->setParameter('{{ value }}', $this->formatValue($value))
                 ->setCode(Date::INVALID_DATE_ERROR)
