-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] Fix trying to access array offset on value of type int #34632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Fix trying to access array offset on value of type int #34632
Conversation
how does your ArrayInput looks like ? this is meant to be an array of strings, so why is there an integer there ? |
@stof I am using lorisleiva/laravel-deployer. |
OK, then we would have to see what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, should target 3.4 actually.
bc3a475
to
96c0d47
Compare
96c0d47
to
069d214
Compare
Thank you @Tavafi. |
…pe int (Tavafi) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix trying to access array offset on value of type int | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no |Tests pass?| yes | License | MIT PHP 7.4 throws an error exception when you are trying to access an array by an integer key. I got this error while I was running a console command: ``` ErrorException: Trying to access array offset on value of type int at /my/project/vendor/symfony/console/Input/ArrayInput.php:110 Exception trace: /my/project/vendor/symfony/console/Input/ArrayInput.php:110 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:87 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:31 /my/project/vendor/laravel/framework/src/Illuminate/Container/Container.php:564 /my/project/vendor/laravel/framework/src/Illuminate/Console/Command.php:179 /my/project/vendor/symfony/console/Command/Command.php:255 /my/project/vendor/laravel/framework/src/Illuminate/Console/Command.php:166 /my/project/vendor/symfony/console/Application.php:934 /my/project/vendor/symfony/console/Application.php:273 /my/project/vendor/symfony/console/Application.php:149 /my/project/vendor/laravel/framework/src/Illuminate/Console/Application.php:89 /my/project/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:122 /my/project/artisan:37 ``` Commits ------- 069d214 [Console] Fix trying to access array offset on value of type int
PHP 7.4 throws an error exception when you are trying to access an array by an integer key.
I got this error while I was running a console command: