bug #34632 [Console] Fix trying to access array offset on value of type int (Tavafi)

nicolas-grekas · nicolas-grekas · commit e23fd9ed0c53 · 2019-11-28T10:15:15.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix trying to access array offset on value of type int | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no |Tests pass?| yes | License | MIT PHP 7.4 throws an error exception when you are trying to access an array by an integer key. I got this error while I was running a console command: ``` ErrorException: Trying to access array offset on value of type int at /my/project/vendor/symfony/console/Input/ArrayInput.php:110 Exception trace: /my/project/vendor/symfony/console/Input/ArrayInput.php:110 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:87 /my/project/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:31 /my/project/vendor/laravel/framework/src/Illuminate/Container/Container.php:564 /my/project/vendor/laravel/framework/src/Illuminate/Console/Command.php:179 /my/project/vendor/symfony/console/Command/Command.php:255 /my/project/vendor/laravel/framework/src/Illuminate/Console/Command.php:166 /my/project/vendor/symfony/console/Application.php:934 /my/project/vendor/symfony/console/Application.php:273 /my/project/vendor/symfony/console/Application.php:149 /my/project/vendor/laravel/framework/src/Illuminate/Console/Application.php:89 /my/project/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:122 /my/project/artisan:37 ``` Commits ------- 069d214 [Console] Fix trying to access array offset on value of type int
diff --git a/src/Symfony/Component/Console/Input/ArrayInput.php b/src/Symfony/Component/Console/Input/ArrayInput.php
@@ -39,8 +39,8 @@ public function __construct(array $parameters, InputDefinition $definition = nul
      */
     public function getFirstArgument()
     {
-        foreach ($this->parameters as $key => $value) {
-            if ($key && '-' === $key[0]) {
+        foreach ($this->parameters as $param => $value) {
+            if ($param && \is_string($param) && '-' === $param[0]) {
                 continue;
             }
 
@@ -107,7 +107,7 @@ public function __toString()
     {
         $params = [];
         foreach ($this->parameters as $param => $val) {
-            if ($param && '-' === $param[0]) {
+            if ($param && \is_string($param) && '-' === $param[0]) {
                 if (\is_array($val)) {
                     foreach ($val as $v) {
                         $params[] = $param.('' != $v ? '='.$this->escapeToken($v) : '');

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@ public function __construct(array $parameters, InputDefinition $definition = nul`
`39`	`39`	`*/`
`40`	`40`	`public function getFirstArgument()`
`41`	`41`	`{`
`42`		`- foreach ($this->parameters as $key => $value) {`
`43`		`- if ($key && '-' === $key[0]) {`
	`42`	`+ foreach ($this->parameters as $param => $value) {`
	`43`	`+ if ($param && \is_string($param) && '-' === $param[0]) {`
`44`	`44`	`continue;`
`45`	`45`	`}`
`46`	`46`
`@@ -107,7 +107,7 @@ public function __toString()`
`107`	`107`	`{`
`108`	`108`	`$params = [];`
`109`	`109`	`foreach ($this->parameters as $param => $val) {`
`110`		`- if ($param && '-' === $param[0]) {`
	`110`	`+ if ($param && \is_string($param) && '-' === $param[0]) {`
`111`	`111`	`if (\is_array($val)) {`
`112`	`112`	`foreach ($val as $v) {`
`113`	`113`	`$params[] = $param.('' != $v ? '='.$this->escapeToken($v) : '');`