8000 [TwigBridge] form button title attr will now trans for button without text by stephen-lewis · Pull Request #34436 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] form button title attr will now trans for button without text #34436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[TwigBridge] form button title attr will now trans for button without text #34436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a3209
A form button widget will now have its title attribute translated eve…
stephen-lewis Nov 18, 2019
88c6cf5
[TwigBridge] Removed unnecessary line break
stephen-lewis Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Symfony/Bridge/Twig/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

5.1.0
-----
* a form button widget will now have its `title` attribute translated
even if its `label` option is `null` or `false`

5.0.0
-----

Expand Down
6 changes: 2 additions & 4 deletions src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
View file 8040
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,11 @@
'%name%': name,
'%id%': id,
}) %}
{%- elseif label is same as(false) -%}
{% set translation_domain = false %}
{%- else -%}
{%- elseif label is not same as(false) -%}
{% set label = name|humanize %}
{%- endif -%}
{%- endif -%}
<button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{{ translation_domain is same as(false) ? label : label|trans(label_translation_parameters, translation_domain) }}</button>
<button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{{ translation_domain is same as(false) or label is same as(false) ? label : label|trans(label_translation_parameters, translation_domain) }}</button>
{%- endblock button_widget -%}

{%- block submit_widget -%}
Expand Down
0