8000 [TwigBridge] form button title attr will now trans for button without text by stephen-lewis · Pull Request #34436 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] form button title attr will now trans for button without text #34436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[TwigBridge] form button title attr will now trans for button without text #34436

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a3209
A form button widget will now have its title attribute translated eve…
stephen-lewis Nov 18, 2019
88c6cf5
[TwigBridge] Removed unnecessary line break
stephen-lewis Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[TwigBridge] Removed unnecessary line break
  • Loading branch information
@stephen-lewis
stephen-lewis committed Dec 17, 2019
commit 88c6cf5b5ac2c0bb0160e8c51ea5c59b3539e9cb
4 changes: 1 addition & 3 deletions src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,7 @@
{% set label = name|humanize %}
{%- endif -%}
{%- endif -%}
<button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{{ translation_domain is same as
(false) or label is same as(false) ? label : label|trans(label_translation_parameters, translation_domain)
}}</button>
<button type="{{ type|default('button') }}" {{ block('button_attributes') }}>{{ translation_domain is same as(false) or label is same as(false) ? label : label|trans(label_translation_parameters, translation_domain) }}</button>
{%- endblock button_widget -%}

{%- block submit_widget -%}
Expand Down
0