8000 [Routing] Fix ContainerLoader and ObjectLoaderTest by fancyweb · Pull Request #34434 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Fix ContainerLoader and ObjectLoaderTest #34434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2019
Merged

[Routing] Fix ContainerLoader and ObjectLoaderTest #34434

merged 1 commit into from
Nov 19, 2019

Conversation

fancyweb
Copy link
Contributor
Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@fancyweb fancyweb force-pushed the routing-fix-object-loader branch from abbd5ab to 81f13f1 Compare November 18, 2019 08:50
@fancyweb fancyweb changed the base branch from master to 5.0 November 18, 2019 08:56
@fancyweb fancyweb force-pushed the routing-fix-object-loader branch 2 times, most recently from 23a7118 to bb92e50 Compare November 18, 2019 09:06
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Nov 18, 2019
@fancyweb fancyweb force-pushed the routing-fix-object-loader branch from bb92e50 to 5147ee2 Compare November 18, 2019 09:35
@fancyweb fancyweb force-pushed the routing-fix-object-loader branch from 5147ee2 to 0e5db6a Compare November 18, 2019 09:36
@fabpot
Copy link
Member
fabpot commented Nov 19, 2019

Thank you @fancyweb.

fabpot added a commit that referenced this pull request Nov 19, 2019
@fabpot
bug #34434 [Routing] Fix ContainerLoader and ObjectLoaderTest (fancyweb)
123c84a 
This PR was merged into the 5.0 branch.

Discussion
----------

[Routing] Fix ContainerLoader and ObjectLoaderTest

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

0e5db6a [Routing] Fix ContainerLoader and ObjectLoaderTest
@fabpot fabpot merged commit 0e5db6a into symfony:5.0 Nov 19, 2019
@fancyweb fancyweb deleted the routing-fix-object-loader branch November 19, 2019 08:05
@fabpot fabpot mentioned this pull request Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Routing Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @fabpot @nicolas-grekas @carsonbot
0