[Routing] Fix ContainerLoader and ObjectLoaderTest

fancyweb · fancyweb · commit abbd5ab8d68f · 2019-11-18T09:28:33.000+01:00
diff --git a/src/Symfony/Component/Routing/Loader/ContainerLoader.php b/src/Symfony/Component/Routing/Loader/ContainerLoader.php
@@ -30,7 +30,7 @@ public function __construct(ContainerInterface $container)
     /**
      * {@inheritdoc}
      */
-    public function supports($resource, $type = null)
+    public function supports($resource, string $type = null)
     {
         return 'service' === $type;
     }
diff --git a/src/Symfony/Component/Routing/Tests/Loader/ObjectLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/ObjectLoaderTest.php
@@ -62,9 +62,6 @@ public function getBadResourceStrings()
         ];
     }
 
-    /**
-     * @group legacy
-     */
     public function testExceptionOnNoObjectReturned()
     {
         $this->expectException('LogicException');

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function __construct(ContainerInterface $container)`
`30`	`30`	`/**`
`31`	`31`	`* {@inheritdoc}`
`32`	`32`	`*/`
`33`		`- public function supports($resource, $type = null)`
	`33`	`+ public function supports($resource, string $type = null)`
`34`	`34`	`{`
`35`	`35`	`return 'service' === $type;`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,6 @@ public function getBadResourceStrings()`
`62`	`62`	`];`
`63`	`63`	`}`
`64`	`64`
`65`		`- /**`
`66`		`- * @group legacy`
`67`		`- */`
`68`	`65`	`public function testExceptionOnNoObjectReturned()`
`69`	`66`	`{`
`70`	`67`	`$this->expectException('LogicException');`