10000 [HttpKernel] Flatten "exception" controller argument if not typed by chalasr · Pull Request #34411 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Flatten "exception" controller argument if not typed #34411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2019
Merged

[HttpKernel] Flatten "exception" controller argument if not typed #34411

merged 1 commit into from
Nov 16, 2019

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 16, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Fixes a BC break and makes it easier for libs to support both debug & error-handler e.g. api-platform/core#3246 (comment)

@chalasr chalasr added this to the 4.4 milestone Nov 16, 2019
@chalasr chalasr mentioned this pull request Nov 16, 2019
Merged
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

nicolas-grekas added a commit that referenced this pull request Nov 16, 2019
@nicolas-grekas
bug #34411 [HttpKernel] Flatten "exception" controller argument if no…
1f73247 
…t typed (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Flatten "exception" controller argument if not typed

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Fixes a BC break and makes it easier for libs to support both debug & error-handler e.g. api-platform/core#3246 (comment)

Commits
-------

585216a [HttpKernel] Flatten "exception" controller argument if not typed
@nicolas-grekas nicolas-grekas merged commit 585216a into symfony:4.4 Nov 16, 2019
@chalasr chalasr deleted the ease-cross-compat branch November 16, 2019 18:47
This was referenced Nov 17, 2019
Merged
Merged
@soyuka soyuka mentioned this pull request Nov 25, 2019
Closed
felixgomez added a commit to phpvigo/workshop-symfony4 that referenced this pull request Nov 26, 2019
@felixgomez
updated composer to symfony 4.4 for (symfony/symfony#34411)
1c7d9ec
chrisrobert43 added a commit to chrisrobert43/workshop-symfony4 that referenced this pull request Dec 20, 2022
@chrisrobert43
updated composer to symfony 4.4 for (symfony/symfony#34411)
44d5ea0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @nicolas-grekas @carsonbot
0