8000 fix compat with Symfony 5 by nicolas-grekas · Pull Request #3246 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

fix compat with Symfony 5 #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2019
Merged

fix compat with Symfony 5 #3246

merged 4 commits into from
Nov 17, 2019

Conversation

nicolas-grekas
Copy link
Contributor
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets -
License MIT
Doc PR -

dunglas
dunglas reviewed Nov 12, 2019
View reviewed changes
@teohhanhui
Copy link
Contributor

This should target 2.5 branch, right?

@nicolas-grekas nicolas-grekas changed the base branch from master to 2.5 November 12, 2019 18:21
@nicolas-grekas
Copy link
Contributor Author

Now targetting branch 2.5

@alanpoulain
Copy link
Member

Errors seem related.

@teohhanhui
Copy link
Contributor

Test mocking needs to handle both cases.

@soyuka
Copy link
Member
soyuka commented Nov 15, 2019

rebased + fixed by @flug waiting for CI

teohhanhui
teohhanhui reviewed Nov 15, 2019
View reviewed changes
teohhanhui
teohhanhui reviewed Nov 15, 2019
View reviewed changes
teohhanhui
teohhanhui reviewed Nov 15, 2019
View reviewed changes
@teohhanhui
Copy link
Contributor
teohhanhui commented Nov 15, 2019 •
edited
Loading

@soyuka You've messed up the indentation in phpstan.neon.dist 😆

I guess you need to install the EditorConfig plugin? 🙈

teohhanhui
teohhanhui reviewed Nov 15, 2019
View reviewed changes
@teohhanhui
Copy link
Contributor

Looks like we still need to add more conditional mocking.

soyuka
soyuka reviewed Nov 15, 2019
View reviewed changes
@chalasr chalasr mentioned this pull request Nov 16, 2019
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Nov 16, 2019
@nicolas-grekas
bug #34411 [HttpKernel] Flatten "exception" controller argument if no…
1f73247 
…t typed (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Flatten "exception" controller argument if not typed

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Fixes a BC break and makes it easier for libs to support both debug & error-handler e.g. api-platform/core#3246 (comment)

Commits
-------

585216a [HttpKernel] Flatten "exception" controller argument if not typed
@soyuka soyuka merged commit 7035e9a into api-platform:2.5 Nov 17, 2019
@soyuka
Copy link
Member
soyuka commented Nov 17, 2019

Thanks @nicolas-grekas @chalasr @teohhanhui @flug

@nicolas-grekas nicolas-grekas deleted the sf5 branch November 17, 2019 10:31
@soyuka soyuka mentioned this pull request Nov 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas left review comments

@teohhanhui teohhanhui teohhanhui approved these changes

@soyuka soyuka soyuka left review comments

@chalasr chalasr chalasr approved these changes

@flug flug flug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nicolas-grekas @teohhanhui @alanpoulain @soyuka @dunglas @flug @chalasr
0